Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from CircleCI to GitHub actions #1087

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Conversation

microbit-matt-hillsdon
Copy link
Collaborator

@microbit-matt-hillsdon microbit-matt-hillsdon commented Jan 17, 2023

Not keeping CircleCI build as there's value in the move to GitHub actions for open source contributions.

Having said that, I've focussed on getting our deployment up and running and there's no PR trigger yet.

Steps require internal GH packages for deployment, but these should be easy to factor out. I'd like forks to be able to at least run e2e and perhaps in time add a template for GH pages deploys.

@github-actions
Copy link

Preview build will be at
https://review-python-editor-v3.microbit.org/gh-actions/

@microbit-matt-hillsdon
Copy link
Collaborator Author

Environment looks good so I'll re-enable the deploy steps:

STAGE: REVIEW
REACT_APP_STAGE: REVIEW
PUBLIC_URL: /gh-actions/
E2E_PUBLIC_URL: /gh-actions/

@microbit-matt-hillsdon microbit-matt-hillsdon marked this pull request as ready for review January 17, 2023 13:44
@microbit-matt-hillsdon microbit-matt-hillsdon changed the title Migrate from CircleCI to GitHub actions. Migrate from CircleCI to GitHub actions Jan 17, 2023
Copy link
Collaborator

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit eebec1b into main Jan 17, 2023
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the gh-actions branch January 17, 2023 19:05
@microbit-matt-hillsdon
Copy link
Collaborator Author

I merged this and monitored the first run.
STAGE was set correctly but PUBLIC_URL was incorrectly set to /main/ so I cancelled the build. I'll look further shortly.

@microbit-matt-hillsdon
Copy link
Collaborator Author

I merged this and monitored the first run. STAGE was set correctly but PUBLIC_URL was incorrectly set to /main/ so I cancelled the build. I'll look further shortly.

This was fixed by #1088 and the current beta deployment is now from GHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants